master

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

master

Torsten Curdt
Hey folks,

just a heads up. It seems like the current master is really quite broken.

Detecting what has changed and re-generating seems to need fixing.
Which right now means often restarting awestruct - which is a pain
with thin. (see the Ctrl-C issue)

Unless someone has time to restore basic functionality we have to hold
back with a new release.
And we really should work on unit/integration tests so that such a big
regression does not sneak in again.

cheers,
Torsten

---------------------------------------------------------------------
Archives: http://talk-archive.awestruct.org/
To unsubscribe, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: master

aslak
What specifically is not working ?
Reply | Threaded
Open this post in threaded view
|

Re: master

Torsten Curdt
> What specifically is not working ?

"Detecting what has changed and re-generating seems to need fixing.
Which right now means often restarting awestruct - which is a pain
with thin. (see the Ctrl-C issue)"

...but seem like I also just broke something when trying to fix the
transformers.

---------------------------------------------------------------------
Archives: http://talk-archive.awestruct.org/
To unsubscribe, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: master

aslak
sure... but.. is it not detecting anything at all? is it not rendering the correct dependencies? Do you have any console output?

Have you killed .awestruct recently? a few commits back there were introduced some changes for the storage format.
Reply | Threaded
Open this post in threaded view
|

Re: master

Torsten Curdt
> sure... but.. is it not detecting anything at all? is it not rendering the
> correct dependencies? Do you have any console output?

It seems to do the right thing for simple static files like css and so on.
But for my posts I only get

 Generating.... done!

when I change them. Maybe a missing dependency when generating the pages?

> Have you killed .awestruct recently? a few commits back there were
> introduced some changes for the storage format.

Yupp.

What concerns me more though is that for the atomizer the transformer
do not get run ...and I don't fully understand why yet. I thought I
found that - but that broke the build.

cheers,
Torsten

---------------------------------------------------------------------
Archives: http://talk-archive.awestruct.org/
To unsubscribe, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: master

aslak
If you only get "Generation Done" it would seem that the changed source_path can't be found as a Page nor as a Layout.

https://github.com/awestruct/awestruct/blob/master/lib/awestruct/engine.rb#L248
Reply | Threaded
Open this post in threaded view
|

Re: master

aslak
I see similar behavior on some of the pages on arquillian.org. Specifically syntatic pages with no 'source' of their own.

            inner_release_page = site.engine.find_and_load_site_page(File.join(@path_prefix, '_release'))
            inner_release_page.output_path = File.join(@path_prefix, release_page_name + '.html')
            inner_release_page.relative_source_path = inner_release_page.output_path

We're for some reason setting the relative_source_path to our generated output_path. Triggering the inner_release_page source_path from where it was loaded has no effect since no page with that source_path exists in site.pages

I regenerate those by touching the layout.
Reply | Threaded
Open this post in threaded view
|

Re: master

Torsten Curdt
Thanks for the pointing towards the right corner of the code.

It seems to work when using load_site_page instead of load_page inside
the extension generating the pages.
But that is so not obvious that we should fix that.

cheers,
Torsten

---------------------------------------------------------------------
Archives: http://talk-archive.awestruct.org/
To unsubscribe, e-mail: [hidden email]